Merged
Conversation
Dead code elimination: - Remove optimized_parser.rs, AthenaConfig, legacy structs, dead methods - 36 allow(dead_code) -> 0 Dependencies: - Remove uuid, anyhow, tempfile; add indexmap Rust idioms: - Fix clippy pedantic, replace unwrap(), strip_prefix, explicit imports - 112 clippy pedantic warnings -> 56 Docker Compose output: - Remove container_name and pull_policy - Deterministic output with BTreeMap/IndexMap - Topological sort, auto-healthcheck, lowercase project name - deploy.restart_policy only with Swarm features
Drop production-ready framing. Position Athena as a solid base with sane defaults, not a magic production guarantee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring: clean codebase, improve generation quality, rewrite README
Context
Full audit of the codebase followed by three axes of improvement:
removal of dead code and unused dependencies, application of Rust idioms,
and improvements to the Docker Compose generation output.
The README has been rewritten to reflect the actual state of the project
instead of overpromising on "production-ready" capabilities.
What changed
Dead code elimination
optimized_parser.rs(325 lines, entirely unused)AthenaConfig, legacy structs incompose.rs,TemplateErrorvariant,ValidationErrorTypeenum,NetworkModeenum,PullPolicyenum#[allow(dead_code)]reduced to 0Unused dependencies
uuid,anyhow,tempfilefrom main dependencies (none were imported)indexmapfor deterministic service orderingRust idioms
unwrap()in production code withget_or_insert_withstrip_prefix/strip_suffixformat_push_stringwithwrite!/writeln!use ast::*) with explicit importsshould_be_verbose,execute_info,calculate_similarity,validate_build_args_against_dockerfileDocker Compose generation
container_namefrom output (was blockingdocker compose --scale)pull_policy: missing(redundant, Docker's default)deploy.restart_policyis now only emitted when Swarm features are used,eliminating the conflict with the top-level
restart:fieldBTreeMapfor deterministic orderingIndexMapwith topological sort (dependencies first)name:field to match Docker conventionsREADME
Metrics
#[allow(dead_code)]